cloud-fan commented on a change in pull request #29104:
URL: https://github.com/apache/spark/pull/29104#discussion_r460773562
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
##########
@@ -1147,4 +1147,40 @@ class JoinSuite extends QueryTest with
SharedSparkSession with AdaptiveSparkPlan
})
}
}
+
+ test("SPARK-32290: SingleColumn Null Aware Anti Join Optimize") {
+ withSQLConf(SQLConf.NULL_AWARE_ANTI_JOIN_OPTIMIZE_ENABLED.key -> "true",
+ SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> Long.MaxValue.toString) {
+ // positive not in subquery case
+ assertJoin((
+ "select * from testData where key not in (select a from testData2)",
+ classOf[BroadcastHashJoinExec]))
+
+ // negative not in subquery case since multi-column is not supported
+ assertJoin((
+ "select * from testData where (key, key + 1) not in (select * from
testData2)",
+ classOf[BroadcastNestedLoopJoinExec]))
+
+ // positive hand-written left anti join
+ // testData.key nullable false
+ // testData3.b nullable true
+ assertJoin((
+ "select * from testData left anti join testData3 ON key = b or
isnull(key = b)",
+ classOf[BroadcastHashJoinExec]))
+
+ // negative hand-written left anti join
Review comment:
is it negative? We do produce `BroadcastHashJoinExec` here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
