huaxingao commented on a change in pull request #29153:
URL: https://github.com/apache/spark/pull/29153#discussion_r461758294
##########
File path: python/pyspark/ml/regression.py
##########
@@ -2391,7 +2404,7 @@ def __repr__(self):
class _FactorizationMachinesParams(_PredictorParams, HasMaxIter, HasStepSize,
HasTol,
- HasSolver, HasSeed, HasFitIntercept,
HasRegParam):
+ HasSolver, HasSeed, HasFitIntercept,
HasRegParam, HasWeightCol):
Review comment:
@viirya Thanks for reviewing. I added ```HasWeightCol``` in
```FactorizationMachinesParams``` in Scala in
https://github.com/apache/spark/pull/28960 when I added
```FMClassificationSummary```. ```ClassificationSummary``` needs weightCol,
https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/classification/ClassificationSummary.scala#L48.
```FMClassifier/Regressor``` doesn't support instance weight yet, so I didn't
add ```setWeightCol``` or set default value in
```FactorizationMachinesParams```.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
