viirya commented on a change in pull request #29262:
URL: https://github.com/apache/spark/pull/29262#discussion_r461972483
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -376,10 +382,14 @@ case class AdaptiveSparkPlanExec(
private def newQueryStage(e: Exchange): QueryStageExec = {
val optimizedPlan = applyPhysicalRules(e.child, queryStageOptimizerRules)
val queryStage = e match {
- case s: ShuffleExchangeExec =>
- ShuffleQueryStageExec(currentStageId, s.copy(child = optimizedPlan))
- case b: BroadcastExchangeExec =>
- BroadcastQueryStageExec(currentStageId, b.copy(child = optimizedPlan))
+ case s: ShuffleExchangeLike =>
+ val newShuffle = applyPhysicalRules(
+ s.withNewChildren(Seq(optimizedPlan)), postStageCreationRules)
+ ShuffleQueryStageExec(currentStageId, newShuffle)
Review comment:
Do we need to make sure `newShuffle` is still `ShuffleExchangeLike`?
Seems custom rules possibly break it?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
##########
@@ -40,13 +41,49 @@ import org.apache.spark.sql.types.StructType
import org.apache.spark.util.MutablePair
import org.apache.spark.util.collection.unsafe.sort.{PrefixComparators,
RecordComparator}
+/**
+ * Common trait for all shuffle exchange implementations to facilitate pattern
matching.
+ */
+trait ShuffleExchangeLike extends Exchange {
+
+ /**
+ * Returns the number of mappers of this shuffle.
+ */
+ def numMappers: Int
+
+ /**
+ * Returns the shuffle partition number.
+ */
+ def numPartitions: Int
+
+ /**
+ * Returns whether the shuffle partition number can be changed.
+ */
+ def canChangeNumPartitions: Boolean
+
+ /**
+ * The asynchronous job that prepares the materializes the shuffle.
Review comment:
This reads weird. A broken sentence?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
