WeichenXu123 commented on pull request #28968: URL: https://github.com/apache/spark/pull/28968#issuecomment-664918280
sync with @HyukjinKwon offline, LGTM except one concern: if we add this thread class instead of fixing it in py4j, can we enable pin thread mode by default in future release ? if enable pin thread mode by default, many user existing code which use plain thread may meet memory leak issue. But fixing it in py4j seems to be difficult, py4j do not know which thread is about to be GCed except thread notifying py4j initiatively ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
