dongjoon-hyun commented on a change in pull request #29280:
URL: https://github.com/apache/spark/pull/29280#discussion_r462028374
##########
File path:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
##########
@@ -157,7 +157,7 @@ class RadixSortSuite extends SparkFunSuite with Logging {
buffer, N, sortType.startByteIdx, sortType.endByteIdx,
sortType.descending, sortType.signed)
val result = collectToArray(buffer, outOffset, N)
- assert(ref.view == result.view)
+ assert(ref.sameElements(result))
Review comment:
Oh, let me try. Thanks
##########
File path:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
##########
@@ -157,7 +157,7 @@ class RadixSortSuite extends SparkFunSuite with Logging {
buffer, N, sortType.startByteIdx, sortType.endByteIdx,
sortType.descending, sortType.signed)
val result = collectToArray(buffer, outOffset, N)
- assert(ref.view == result.view)
+ assert(ref.sameElements(result))
Review comment:
Ur, do you mean to use `IndexSeqView` still like `ref.view ===
result.view`?
##########
File path:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
##########
@@ -157,7 +157,7 @@ class RadixSortSuite extends SparkFunSuite with Logging {
buffer, N, sortType.startByteIdx, sortType.endByteIdx,
sortType.descending, sortType.signed)
val result = collectToArray(buffer, outOffset, N)
- assert(ref.view == result.view)
+ assert(ref.sameElements(result))
Review comment:
nvm. I check that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
