Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5235#discussion_r27353855
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -179,6 +179,7 @@ trait ScalaReflection {
case t if t <:< definitions.ShortTpe => Schema(ShortType, nullable =
false)
case t if t <:< definitions.ByteTpe => Schema(ByteType, nullable =
false)
case t if t <:< definitions.BooleanTpe => Schema(BooleanType,
nullable = false)
+ case other => sys.error(s"Schema for type $other is currently not
supported")
--- End diff --
(Yeah I corrected my comment right after I made it -- of course `other` is
required here.) I don't feel strongly about it; all else equal
`RuntimeException` is not ideal, but it's more important to be consistent with
similar code than anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
