cloud-fan commented on a change in pull request #29268:
URL: https://github.com/apache/spark/pull/29268#discussion_r461496363
##########
File path:
core/src/main/scala/org/apache/spark/executor/ShuffleWriteMetrics.scala
##########
@@ -32,6 +33,7 @@ class ShuffleWriteMetrics private[spark] () extends
ShuffleWriteMetricsReporter
private[executor] val _bytesWritten = new LongAccumulator
private[executor] val _recordsWritten = new LongAccumulator
private[executor] val _writeTime = new LongAccumulator
+ private[executor] val _rowCountInfo = new CollectionAccumulator[RowCountInfo]
Review comment:
is it possible to reuse the `_recordsWritten` accumulator?
##########
File path:
core/src/main/scala/org/apache/spark/executor/ShuffleWriteMetrics.scala
##########
@@ -32,6 +33,7 @@ class ShuffleWriteMetrics private[spark] () extends
ShuffleWriteMetricsReporter
private[executor] val _bytesWritten = new LongAccumulator
private[executor] val _recordsWritten = new LongAccumulator
private[executor] val _writeTime = new LongAccumulator
+ private[executor] val _rowCountInfo = new CollectionAccumulator[RowCountInfo]
Review comment:
nvm, we need to collect the size array for reducers per task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
