Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5242#discussion_r27353884
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -38,6 +38,7 @@ import org.apache.spark.{SparkEnv, Logging,
SecurityManager, SparkConf}
import org.apache.spark.deploy.yarn.YarnSparkHadoopUtil._
import org.apache.spark.scheduler.cluster.CoarseGrainedSchedulerBackend
import org.apache.spark.util.AkkaUtils
+import java.lang.reflect.Constructor
--- End diff --
Nit, import ordering here.
This looks like a pretty straightforward change, yeah. Too bad this
requires reflection, but it's clean. I look forward to being able to assume
later versions of YARN / Hadoop to undo some of this. (Although requiring 2.6
probably won't happen too soon.)
The key use case this enables is, for example, running a Spark app on a
subset of a cluster's machines that are labeled as having a GPU. I like this
given the relatively low impact simple change and the upside to what it enables.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
