cloud-fan commented on a change in pull request #29273:
URL: https://github.com/apache/spark/pull/29273#discussion_r461750844
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala
##########
@@ -490,8 +490,10 @@ case class ApplyColumnarRulesAndInsertTransitions(conf:
SQLConf, columnarRules:
// The tree feels kind of backwards
// Columnar Processing will start here, so transition from row to
columnar
RowToColumnarExec(insertTransitions(plan))
- } else {
+ } else if (!plan.isInstanceOf[RowToColumnarExec]) {
Review comment:
do you mean
https://github.com/apache/spark/pull/29067/files#diff-3a92abd70b28650055b16d8a101a95c3R55
?
I can wait for it to be merged, and add something similar to
`RowToColumnarExec`.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala
##########
@@ -490,8 +490,10 @@ case class ApplyColumnarRulesAndInsertTransitions(conf:
SQLConf, columnarRules:
// The tree feels kind of backwards
// Columnar Processing will start here, so transition from row to
columnar
RowToColumnarExec(insertTransitions(plan))
- } else {
+ } else if (!plan.isInstanceOf[RowToColumnarExec]) {
Review comment:
do you mean
https://github.com/apache/spark/pull/29067/files#diff-3a92abd70b28650055b16d8a101a95c3R55
?
I can wait for it to be merged, and add something similar for
`RowToColumnarExec`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
