Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-87436152
To clarify something: do you expect there to be a {{log4j.properties}} file
in the slider assembly JAR? because there isn't one, not in trunk@ 0e2753ff :
```bash
$ mvn package -DskipTests -Pyarn -Phadoop-2.4 -Dhadoop.version=2.6.0
-Dhbase.profile=hadoop2 -Phive
$ pushd assembly/target/scala-2.10/
$ unzip spark-assembly-1.4.0-SNAPSHOT-hadoop2.6.0.jar
$ find . -name log4j.properties
$
```
Looking in the source tree, there are only such files in the test
resources, other than one in `kinesis-asl`
```bash
$ find . -name log4j.properties
./bagel/src/test/resources/log4j.properties
./bagel/target/scala-2.10/test-classes/log4j.properties
./core/src/test/resources/log4j.properties
./core/target/scala-2.10/test-classes/log4j.properties
./external/flume/src/test/resources/log4j.properties
./external/flume/target/scala-2.10/test-classes/log4j.properties
./external/flume-sink/src/test/resources/log4j.properties
./external/flume-sink/target/scala-2.10/test-classes/log4j.properties
./external/kafka/src/test/resources/log4j.properties
./external/kafka/target/scala-2.10/test-classes/log4j.properties
./external/mqtt/src/test/resources/log4j.properties
./external/mqtt/target/scala-2.10/test-classes/log4j.properties
./external/twitter/src/test/resources/log4j.properties
./external/twitter/target/scala-2.10/test-classes/log4j.properties
./external/zeromq/src/test/resources/log4j.properties
./external/zeromq/target/scala-2.10/test-classes/log4j.properties
./extras/java8-tests/src/test/resources/log4j.properties
./extras/kinesis-asl/src/main/resources/log4j.properties
./extras/kinesis-asl/src/test/resources/log4j.properties
./graphx/src/test/resources/log4j.properties
./graphx/target/scala-2.10/test-classes/log4j.properties
./launcher/src/test/resources/log4j.properties
./launcher/target/scala-2.10/test-classes/log4j.properties
./mllib/src/test/resources/log4j.properties
./mllib/target/scala-2.10/test-classes/log4j.properties
./repl/src/test/resources/log4j.properties
./repl/target/scala-2.10/test-classes/log4j.properties
./sql/catalyst/src/test/resources/log4j.properties
./sql/catalyst/target/scala-2.10/test-classes/log4j.properties
./sql/core/src/test/resources/log4j.properties
./sql/core/target/scala-2.10/test-classes/log4j.properties
./sql/hive/src/test/resources/log4j.properties
./sql/hive/target/scala-2.10/test-classes/log4j.properties
./streaming/src/test/resources/log4j.properties
./streaming/target/scala-2.10/test-classes/log4j.properties
./yarn/src/test/resources/log4j.properties
./yarn/target/scala-2.10/test-classes/log4j.properties
```
This pull request will make sure that none of the test log4j files will
make it onto the classpath of any downstream tests importing the test JARs.
I manually tested this by
1. Switching to this pull-request branch
1. creating a log4j file `core/src/main/resources/log4j.properties` file
echo "#inserted into core" >
core/src/main/resources/log4.properties
1. building a clean package
1. verifying the file was in the slider-core JAR
1. verifying it made it through to the assembly JAR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
