tgravescs commented on a change in pull request #29281:
URL: https://github.com/apache/spark/pull/29281#discussion_r462305035
##########
File path: core/src/main/scala/org/apache/spark/resource/ResourceAllocator.scala
##########
@@ -56,7 +56,7 @@ trait ResourceAllocator {
def availableAddrs: Seq[String] = addressAvailabilityMap
.flatMap { case (addr, available) =>
(0 until available).map(_ => addr)
- }.toSeq
+ }.toSeq.sorted
Review comment:
we should do assignedAddrs as well to keep them consistent. There are
tests using it but I didn't see
##########
File path: core/src/main/scala/org/apache/spark/resource/ResourceAllocator.scala
##########
@@ -56,7 +56,7 @@ trait ResourceAllocator {
def availableAddrs: Seq[String] = addressAvailabilityMap
.flatMap { case (addr, available) =>
(0 until available).map(_ => addr)
- }.toSeq
+ }.toSeq.sorted
Review comment:
we should do assignedAddrs as well to keep them consistent. There are
tests using it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
