HyukjinKwon commented on a change in pull request #29298:
URL: https://github.com/apache/spark/pull/29298#discussion_r462787946
##########
File path:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
##########
@@ -258,6 +260,33 @@ class SubmitRestProtocolSuite extends SparkFunSuite {
| }
|}
""".stripMargin
+ } else {
+ s"""
+ |{
+ | "action" : "CreateSubmissionRequest",
+ | "appArgs" : [ "two slices", "a hint of cinnamon" ],
+ | "appResource" : "honey-walnut-cherry.jar",
+ | "clientSparkVersion" : "1.2.3",
+ | "environmentVariables" : {
+ | "PATH" : "/dev/null"
+ | },
+ | "mainClass" : "org.apache.spark.examples.SparkPie",
+ | "sparkProperties" : {
+ | "spark.driver.extraLibraryPath" : "pickle.jar",
+ | "spark.jars" : "mayonnaise.jar,ketchup.jar",
+ | "spark.driver.supervise" : "false",
+ | "spark.driver.memory" : "1024m",
Review comment:
Maybe `"${Utils.DEFAULT_DRIVER_MEM_MB}m"`?
##########
File path:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
##########
@@ -258,6 +260,33 @@ class SubmitRestProtocolSuite extends SparkFunSuite {
| }
|}
""".stripMargin
+ } else {
+ s"""
+ |{
+ | "action" : "CreateSubmissionRequest",
+ | "appArgs" : [ "two slices", "a hint of cinnamon" ],
+ | "appResource" : "honey-walnut-cherry.jar",
+ | "clientSparkVersion" : "1.2.3",
+ | "environmentVariables" : {
+ | "PATH" : "/dev/null"
+ | },
+ | "mainClass" : "org.apache.spark.examples.SparkPie",
+ | "sparkProperties" : {
+ | "spark.driver.extraLibraryPath" : "pickle.jar",
+ | "spark.jars" : "mayonnaise.jar,ketchup.jar",
+ | "spark.driver.supervise" : "false",
+ | "spark.driver.memory" : "1024m",
Review comment:
Eh,
https://github.com/apache/spark/pull/29298/files#diff-2ebc20516434bc6dc6ad4e9698e9b15bR239-R261
has `"${Utils.DEFAULT_DRIVER_MEM_MB}m"` here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
