cloud-fan commented on a change in pull request #29291:
URL: https://github.com/apache/spark/pull/29291#discussion_r462958983
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##########
@@ -184,8 +227,8 @@ object RewriteDistinctAggregates extends Rule[LogicalPlan] {
}
}
- // Aggregation strategy can handle queries with a single distinct group.
- if (distinctAggGroups.size > 1) {
Review comment:
For `count(distinct c1), count(c2) FILTER ...`, we don't apply this rule
previously and it works well. Why do we need to apply this rule now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
