maropu commented on a change in pull request #29146:
URL: https://github.com/apache/spark/pull/29146#discussion_r463019812
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -962,8 +962,8 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
test("SET commands semantics using sql()") {
spark.sessionState.conf.clear()
- val testKey = "test.key.0"
- val testVal = "test.val.0"
+ val testKey = "test.key.k0"
Review comment:
I tried it though, I found just adding `DIGIT+`([Actually, I added
`INTEGER_VALUE`
instead](https://github.com/apache/spark/pull/29146/files#diff-8c1cb2af4aa1109e08481dae79052cc3R280))
there did not work well...
For example, a pattern below was okay;
```
SET spark:sql:3=value or SET 1:2:key=value
```
https://github.com/apache/spark/pull/29146/files#diff-e9f35fff083788e6494cb1220a792b99R90-R92
But, a following pattern couldn't be parsed;
```
SET spark.sql.3=value or SET 1.2.key=value
```
https://github.com/apache/spark/pull/29146/files#diff-e9f35fff083788e6494cb1220a792b99R105-R106
That's because `.3` and `1.2` are regarded as the `DECIMAL_VALUE` tokens,
so the `configKey` parsing rule cannot match them correctly. I looked for an
approach to avoid it, but I haven't found a good idea so far.
Any idea for this? Anyway, I will keep looking for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
