HyukjinKwon commented on a change in pull request #29306:
URL: https://github.com/apache/spark/pull/29306#discussion_r463055637
##########
File path: dev/run-tests.py
##########
@@ -610,8 +610,14 @@ def main():
# Install SparkR
should_only_test_modules = opts.modules is not None
- if not should_only_test_modules:
+ test_modules = []
+ if should_only_test_modules:
+ str_test_modules = [m.strip() for m in opts.modules.split(",")]
+ test_modules = [m for m in modules.all_modules if m.name in
str_test_modules]
+
+ if not should_only_test_modules or modules.sparkr in test_modules:
Review comment:
I piggyback this change together. We don't need to install SparkR when
`--modules` is specified except that it includes `sparkr`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
