cloud-fan commented on a change in pull request #29291:
URL: https://github.com/apache/spark/pull/29291#discussion_r463395906
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##########
@@ -207,13 +257,30 @@ object RewriteDistinctAggregates extends
Rule[LogicalPlan] {
val distinctAggChildren = distinctAggGroups.keySet.flatten.toSeq.distinct
val distinctAggChildAttrMap =
distinctAggChildren.map(expressionAttributePair)
val distinctAggChildAttrs = distinctAggChildAttrMap.map(_._2)
+ // Setup all the filters in distinct aggregate.
+ val distinctAggExprs = aggExpressions
+ .filter(e => e.isDistinct && e.children.exists(!_.foldable))
Review comment:
I think we should just use `distinctAggs` here. We can add test for this
case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
