cloud-fan commented on a change in pull request #29307:
URL: https://github.com/apache/spark/pull/29307#discussion_r463396209
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeLocalShuffleReader.scala
##########
@@ -140,9 +140,9 @@ object OptimizeLocalShuffleReader {
def canUseLocalShuffleReader(plan: SparkPlan): Boolean = plan match {
case s: ShuffleQueryStageExec =>
- s.shuffle.canChangeNumPartitions
+ s.shuffle.canChangeNumPartitions && s.mapStats.isDefined
Review comment:
yea, otherwise we will hit
```
val splitPoints = if (numMappers == 0) {
Seq.empty
} else ...
```
which creates a local reader with 0 partitions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
