c21 commented on a change in pull request #29277:
URL: https://github.com/apache/spark/pull/29277#discussion_r463417776
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
##########
@@ -903,6 +904,10 @@ case class CollapseCodegenStages(
// The children of SortMergeJoin should do codegen separately.
j.withNewChildren(j.children.map(
child => InputAdapter(insertWholeStageCodegen(child))))
+ case j: ShuffledHashJoinExec =>
+ // The children of ShuffledHashJoin should do codegen separately.
+ j.withNewChildren(j.children.map(
Review comment:
> We need to accumulate the CodegenSupport.inputRDDs, but
WholeStageCodegenExec only supports up to 2 input RDDs for now.
Yes. Agreed. `SortMergeJoinExec` took the decision to do codegen for
children separately, it's just simpler without getting into these limitations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
