maropu commented on a change in pull request #29303:
URL: https://github.com/apache/spark/pull/29303#discussion_r463483396
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala
##########
@@ -141,17 +174,17 @@ private[hive] class SparkGetColumnsOperation(
column.name, // COLUMN_NAME
toJavaSQLType(column.dataType.sql).asInstanceOf[AnyRef], // DATA_TYPE
column.dataType.sql, // TYPE_NAME
- null, // COLUMN_SIZE
+ getColumnSize(column.dataType).map(_.asInstanceOf[AnyRef]).orNull,
// COLUMN_SIZE
Review comment:
Could you make the title and description clearer? e.g., which field does
this PR add (COLUMN_SIZE, DECIMAL_DIGITS, and NUM_PREC_RADIX, and
ORDINAL_POSITION?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
