maropu commented on a change in pull request #29317:
URL: https://github.com/apache/spark/pull/29317#discussion_r463629913
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -819,8 +819,10 @@ object JdbcUtils extends Logging {
if (null != customSchema && customSchema.nonEmpty) {
Review comment:
Oh, I see. We need to accept a nested schema in `customSchema`? I
checked the original PR https://github.com/apache/spark/pull/18266, but I
couldn't find test cases for nested schemas. So, I'm not sure this is an
expected behaviour... cc: @ wangyum
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -819,8 +819,10 @@ object JdbcUtils extends Logging {
if (null != customSchema && customSchema.nonEmpty) {
Review comment:
Oh, I see. We need to accept a nested schema in `customSchema`? I
checked the original PR https://github.com/apache/spark/pull/18266, but I
couldn't find test cases for nested schemas. So, I'm not sure this is an
expected behaviour... cc: @wangyum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
