srowen commented on a change in pull request #29242:
URL: https://github.com/apache/spark/pull/29242#discussion_r463768321



##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -674,7 +674,7 @@ def cache(self):
         .. note:: The default storage level has changed to `MEMORY_AND_DISK` 
to match Scala in 2.0.
         """
         self.is_cached = True
-        self._jdf.cache()
+        self.persist(StorageLevel.MEMORY_AND_DISK)

Review comment:
       OK, right. That could be a simpler fix. But then I'm still not so much 
following why there is a behavior difference per 
https://github.com/apache/spark/pull/29242#discussion_r462086489 I'm trying to 
understand whether this difference is expected or not, per earlier comments.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to