maropu commented on a change in pull request #28841:
URL: https://github.com/apache/spark/pull/28841#discussion_r463960973



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -561,6 +564,367 @@ class FileBasedDataSourceSuite extends QueryTest
     }
   }
 
+  test("SPARK-31962 - when modifiedAfter specified " +
+      "with a past date") {
+    withTempDir { dir =>
+      withSQLConf(SQLConf.SESSION_LOCAL_TIMEZONE.key -> "UTC") {
+        val path = new Path(dir.getCanonicalPath)
+        val file = new File(dir, "file1.csv")

Review comment:
       Could you add tests for multiple file cases? Probably, I think you might 
be able to use `(new File("/tmp/file.csv")).setLastModified(xxx)` to control 
timestamp.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to