cloud-fan commented on a change in pull request #29328:
URL: https://github.com/apache/spark/pull/29328#discussion_r464203078
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##########
@@ -245,15 +245,22 @@ class DataFrameReader private[sql](sparkSession:
SparkSession) extends Logging {
"read files of Hive data source directly.")
}
+ val updatedPaths = if (paths.length == 1) {
Review comment:
If we are worried about silent result changing, we can fail if there are
`path` option and `load` is called with path parameters. The error message
should ask users to either remove the `path` options, we put it into the `load`
parameters.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##########
@@ -245,15 +245,22 @@ class DataFrameReader private[sql](sparkSession:
SparkSession) extends Logging {
"read files of Hive data source directly.")
}
+ val updatedPaths = if (paths.length == 1) {
Review comment:
If we are worried about silent result changing, we can fail if there are
`path` option and `load` is called with path parameters. The error message
should ask users to either remove the `path` options, or put it into the `load`
parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
