attilapiros commented on a change in pull request #29090:
URL: https://github.com/apache/spark/pull/29090#discussion_r464359379
##########
File path:
launcher/src/main/java/org/apache/spark/launcher/SparkClassCommandBuilder.java
##########
@@ -108,7 +108,7 @@
}
String mem = firstNonEmpty(memKey != null ? System.getenv(memKey) : null,
DEFAULT_MEM);
- cmd.add("-Xmx" + mem);
+ cmd.add("-Xmx" + addDefaultMSuffixIfNeeded(mem));
Review comment:
Thanks I really focused on XMX and XMS settings but now I see there
another error at
https://github.com/apache/spark/blob/cc495c1c45ac0648156b662fdc308287c79f3fdc/core/src/main/scala/org/apache/spark/memory/UnifiedMemoryManager.scala#L225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
