GitHub user brennonyork opened a pull request:
https://github.com/apache/spark/pull/5269
[HOTFIX][SPARK-4123]: Updated to fix bug where multiple dependencies added
breaks Github output
Currently there is a bug whereby if a new patch introduces more than one
new dependency (or removes more than one) it breaks the Github post output (see
[this
build](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29399/consoleFull)).
This hotfix will remove `awk` print statements in place of `printf` so as not
to automatically add the newline character. It is then escaped and added
directly at the end of the `awk` statement. This should take a failed build
output such as:
```json
api_response: {
"message": "Problems parsing JSON",
"documentation_url": "https://developer.github.com/v3";
}
> data: {"body": " [Test build #29400 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29400/consoleFull)
for PR 5266 at commit
[`2aa4be0`](https://github.com/apache/spark/commit/2aa4be0e1d7ce052f8c901c6d9462c611c3a920a).\n
* This patch **passes all tests**.\n * This patch merges cleanly.\n * This
patch adds the following public classes _(experimental)_:\n * `class IDF
extends Estimator[IDFModel] with IDFParams `\n * `class Normalizer extends
UnaryTransformer[Vector, Vector, Normalizer] `\n\n * This patch **adds the
following new dependencies:**\n * `avro-1.7.7.jar`
* `breeze-macros_2.10-0.11.2.jar`
* `breeze_2.10-0.11.2.jar`\n * This patch **removes the following
dependencies:**\n * `avro-1.7.6.jar`
* `breeze-macros_2.10-0.11.1.jar`
* `breeze_2.10-0.11.1.jar`"}
```
and turn it into:
```json
api_response: {
"message": "Problems parsing JSON",
"documentation_url": "https://developer.github.com/v3";
}
> data: {"body": " [Test build #29400 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29400/consoleFull)
for PR 5266 at commit
[`2aa4be0`](https://github.com/apache/spark/commit/2aa4be0e1d7ce052f8c901c6d9462c611c3a920a).\n
* This patch **passes all tests**.\n * This patch merges cleanly.\n * This
patch adds the following public classes _(experimental)_:\n * `class IDF
extends Estimator[IDFModel] with IDFParams `\n * `class Normalizer extends
UnaryTransformer[Vector, Vector, Normalizer] `\n\n * This patch **adds the
following new dependencies:**\n * `avro-1.7.7.jar`\n *
`breeze-macros_2.10-0.11.2.jar`\n * `breeze_2.10-0.11.2.jar`\n * This patch
**removes the following dependencies:**\n * `avro-1.7.6.jar`\n *
`breeze-macros_2.10-0.11.1.jar`\n * `breeze_2.10-0.11.1.jar`"}
```
I've tested this locally and all worked.
/cc @srowen @pwendell @nchammas
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brennonyork/spark HOTFIX-SPARK-4123
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5269.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5269
----
commit a4410680b9cc1ed4616127f320f51198783c250c
Author: Brennon York <[email protected]>
Date: 2015-03-30T15:37:01Z
Updated awk to use printf and to manually insert newlines so that the JSON
github string when posted is corrected
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
