gatorsmile commented on a change in pull request #29338:
URL: https://github.com/apache/spark/pull/29338#discussion_r464493250



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala
##########
@@ -1420,4 +1420,16 @@ class ColumnExpressionSuite extends QueryTest with 
SharedSparkSession {
       }.getMessage should include("No such struct field b in a, B")
     }
   }
+
+  test("SPARK-32521: withField with statically evaluable arguments should 
succeed") {

Review comment:
       The end users can see the examples. To ensure we do not have a 
regression, could you add all the examples to the test suite? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to