holdenk commented on pull request #29211: URL: https://github.com/apache/spark/pull/29211#issuecomment-668340555
I've added a bunch of tests around the timestamp stuff. I think it's got all of the cases folks were asking for covered, and in the discussion on the PR to this PR it seems like we're in agreement that while the timestamps are complex, it beats the alternative of maybe having a race condition and trying to mitigate with a thread sleep. With that in mind, if there is no other active discussion I'll consider this to be a lazy consensus. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
