viirya commented on a change in pull request #29324:
URL: https://github.com/apache/spark/pull/29324#discussion_r464790560
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -184,15 +189,62 @@ abstract class JdbcDialect extends Serializable {
/**
* Rename an existing table.
*
- * TODO (SPARK-32382): Override this method in the dialects that don't
support such syntax.
- *
* @param oldTable The existing table.
* @param newTable New name of the table.
* @return The SQL statement to use for renaming the table.
*/
def renameTable(oldTable: String, newTable: String): String = {
s"ALTER TABLE $oldTable RENAME TO $newTable"
}
+
+ /**
+ * Alter an existing table.
+ * TODO (SPARK-32523): Override this method in the dialects that have
different syntax.
+ *
+ * @param tableName The name of the table to be altered.
+ * @param changes Changes to apply to the table.
+ * @return The SQL statements to use for altering the table.
+ */
+ def alterTable(tableName: String, changes: Seq[TableChange]): Array[String]
= {
+ val updateClause = ArrayBuilder.make[String]
+ for (change <- changes) {
+ change match {
+ case add: AddColumn =>
+ add.fieldNames match {
+ case Array(name) =>
+ val dataType = JdbcUtils.getJdbcType(add.dataType(),
this).databaseTypeDefinition
+ updateClause += s"ALTER TABLE $tableName ADD COLUMN $name
$dataType"
+ }
+ case rename: RenameColumn =>
+ rename.fieldNames match {
+ case Array(name) =>
+ updateClause += s"ALTER TABLE $tableName RENAME COLUMN $name TO
${rename.newName}"
+ }
+ case delete: DeleteColumn =>
+ delete.fieldNames match {
+ case Array(name) =>
+ updateClause += s"ALTER TABLE $tableName DROP COLUMN $name"
+ }
+ case update: UpdateColumnType =>
+ update.fieldNames match {
+ case Array(name) =>
+ val dataType = JdbcUtils.getJdbcType(update.newDataType(), this)
+ .databaseTypeDefinition
+ updateClause += s"ALTER TABLE $tableName ALTER COLUMN $name
$dataType"
+ }
+ case update: UpdateColumnNullability =>
+ update.fieldNames match {
+ case Array(name) =>
+ val nullable = if (update.nullable()) "NULL" else "NOT NULL"
+ updateClause += s"ALTER TABLE $tableName ALTER COLUMN $name SET
" + nullable
Review comment:
Since you already use s"", just put `nullable` into it too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
