Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/5261#issuecomment-87768648
Hmm. I see. `spark-daemon.sh` calls this script directly, but does not set
`SPARK_HOME.` Makes sense.
One comment: doing the following in a script that is sources is a little
weird:
FWDIR="$(cd "`dirname "$0"`"/..; pwd)"
That's because `$0` actually refers to the script that is sourcing this
one, not `load-spark-env.sh`. In Spark, though, the code above probably still
works because of where all the scripts are.
I'd put a comment in the code about that, maybe, or use `$BASH_SOURCE`
instead. Other than that, looks like a correct change to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
