c21 commented on a change in pull request #29342:
URL: https://github.com/apache/spark/pull/29342#discussion_r465330063
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -305,6 +315,27 @@ private[joins] class UnsafeHashedRelation(
override def read(kryo: Kryo, in: Input): Unit = Utils.tryOrIOException {
read(() => in.readInt(), () => in.readLong(), in.readBytes)
}
+
+ override def values(): Iterator[InternalRow] = {
+ if (isLookupAware) {
Review comment:
@cloud-fan - sounds good. Added a rudimentary trivial implementation of
`values()` in `LongHashedRelation`. Also added a unit test in
`HashedRelationSuite.scala` - `test("SPARK-32399: test values() method for
HashedRelation")` to test behavior for `values()` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
