HyukjinKwon commented on a change in pull request #29324:
URL: https://github.com/apache/spark/pull/29324#discussion_r465493233
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -184,7 +179,7 @@ object JdbcUtils extends Logging {
}
}
- private def getJdbcType(dt: DataType, dialect: JdbcDialect): JdbcType = {
+ private[sql] def getJdbcType(dt: DataType, dialect: JdbcDialect): JdbcType =
{
Review comment:
It's okay to remove `private[sql]` because `execution` is already in the
private package (see also SPARK-16964)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
