leanken commented on a change in pull request #29304:
URL: https://github.com/apache/spark/pull/29304#discussion_r465521051
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
##########
@@ -225,9 +223,10 @@ case class BroadcastHashJoinExec(
protected override def codegenAnti(ctx: CodegenContext, input:
Seq[ExprCode]): String = {
if (isNullAwareAntiJoin) {
val (broadcastRelation, relationTerm) = prepareBroadcast(ctx)
- val (keyEv, anyNull) = genStreamSideJoinKey(ctx, input)
+ val (keyEv, anyNull) = genStreamSideJoinKey(ctx, input, true)
Review comment:
because if it's a single Long key, keyEv will be codegen as java long,
but not UnsafeRow. In InvertedIndexHashedRelation, it only takes UnsafeRow as
input to lookup in buildSide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
