skambha commented on pull request #29125:
URL: https://github.com/apache/spark/pull/29125#issuecomment-669396932


   
   >How about this: we force to enable ANSI for decimal sum, so that the 
behavior is the same without fixing the UnsafeRow >bug? It's not an ideal fix 
but should be safer to backport. @skambha what do you think? Can you help to do 
it?
   
   Not sure if I understand correctly, so can you clarify.  The reason I ask is 
: Currently, the v3.0 Sum has a ANSI mode in the evaluationExpression and 
forcing that to be true will not give us much.    We will still run into the 
problems I mentioned a few comments earlier. 
   
   --
   @cloud-fan, Just to clarify that we are in agreement. The first step is to 
revert this back port.  Can you confirm please.  
   Yes, I can submit a PR to do this UnsafeRow revert for the v3.0.x and 
v2.x.x.   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to