srowen commented on a change in pull request #29377:
URL: https://github.com/apache/spark/pull/29377#discussion_r466469201
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -759,15 +759,17 @@ private[hive] class HiveClientImpl(
dbName: String,
pattern: String,
tableType: CatalogTableType): Seq[String] = withHiveState {
+ val hiveTableType = toHiveTableType(tableType)
try {
// Try with Hive API getTablesByType first, it's supported from Hive
2.3+.
- shim.getTablesByType(client, dbName, pattern, toHiveTableType(tableType))
+ shim.getTablesByType(client, dbName, pattern, hiveTableType)
} catch {
case _: UnsupportedOperationException =>
// Fallback to filter logic if getTablesByType not supported.
val tableNames = client.getTablesByPattern(dbName, pattern).asScala
- val tables = getTablesByName(dbName, tableNames).filter(_.tableType ==
tableType)
Review comment:
It's fine if we 'break' Scala 2.13 a bit in master while we're still
getting it working, if it makes it easier to not reason about it. If you carry
back to .toSeq / .toMap-style changes into 3.0 it's fine though, still works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
