dongjoon-hyun commented on a change in pull request #28761:
URL: https://github.com/apache/spark/pull/28761#discussion_r466517363
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/orc/OrcScanBuilder.scala
##########
@@ -60,10 +61,8 @@ case class OrcScanBuilder(
// changed `hadoopConf` in executors.
OrcInputFormat.setSearchArgument(hadoopConf, f, schema.fieldNames)
}
- val dataTypeMap = schema.map(f => quoteIfNeeded(f.name) ->
f.dataType).toMap
- // TODO (SPARK-25557): ORC doesn't support nested predicate pushdown, so
they are removed.
- val newFilters = filters.filter(!_.containsNestedColumn)
- _pushedFilters = OrcFilters.convertibleFilters(schema, dataTypeMap,
newFilters).toArray
Review comment:
Just a question. Is it safe to touch this `DSv2` code path when the
configuration still has `effective with file-based data sources in DSv1.`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
