karuppayya commented on a change in pull request #28804:
URL: https://github.com/apache/spark/pull/28804#discussion_r466749198
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##########
@@ -680,6 +688,16 @@ case class HashAggregateExec(
private def doProduceWithKeys(ctx: CodegenContext): String = {
val initAgg = ctx.addMutableState(CodeGenerator.JAVA_BOOLEAN, "initAgg")
+ if (skipPartialAggregate) {
+ avoidSpillInPartialAggregateTerm = ctx.
+ addMutableState(CodeGenerator.JAVA_BOOLEAN,
+ "avoidPartialAggregate",
+ term => s"$term = ${Utils.isTesting};")
+ }
+ val childrenConsumed = ctx.
+ addMutableState(CodeGenerator.JAVA_BOOLEAN, "childrenConsumed")
+ rowCountTerm = ctx.
+ addMutableState(CodeGenerator.JAVA_LONG, "rowCount")
Review comment:
I didnot add these behind the flag since it was resulting in addition of
few if..else checks. Hence avoided them since these variables are harmless.
Reg initialization, since they are field members, they get initialized to
`false` and `0` respectively
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
