maropu commented on a change in pull request #28804:
URL: https://github.com/apache/spark/pull/28804#discussion_r466757897
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##########
@@ -409,6 +411,12 @@ case class HashAggregateExec(
private var fastHashMapTerm: String = _
private var isFastHashMapEnabled: Boolean = false
+ private var avoidSpillInPartialAggregateTerm: String = _
+ private val skipPartialAggregate = sqlContext.conf.skipPartialAggregate &&
+ AggUtils.areAggExpressionsPartial(modes) &&
find(_.isInstanceOf[ExpandExec]).isEmpty
Review comment:
hm, I see... But, I think the current approach looks dangerous because
we might add a new plan having the same assumption in feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
