Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4435#discussion_r27444853
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
    @@ -138,7 +138,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends 
WebUIPage("") {
                   if (shouldShowCompletedJobs) {
                     <li>
                       <a href="#completed"><strong>Completed Jobs:</strong></a>
    -                  {completedJobs.size}
    +                  {listener.numCompletedJobs}
    --- End diff --
    
    When the number of completed jobs is greater than the retention limits, 
this will now show the total number of jobs ever run rather than capping out at 
1000.  I think I remember someone suggesting that we say something like 
"(Completed jobs: 3000 (only showing 1000))" in these cases, but even without 
doing that I think this is fine since I think it's less confusing than the 
current behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to