cloud-fan commented on a change in pull request #29328:
URL: https://github.com/apache/spark/pull/29328#discussion_r466836253
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##########
@@ -229,6 +229,7 @@ class DataFrameReader private[sql](sparkSession:
SparkSession) extends Logging {
*/
def load(path: String): DataFrame = {
// force invocation of `load(...varargs...)`
+ verifyPathOptionDoesNotExist()
Review comment:
Think about `df.write.option(path).load(paths)`. The current behavior is:
1. if `paths` is just a single path, it overrides the path option.
2. otherwise, it combines the path option.
I would say the reasonable behavior is to always override the path option if
`paths` is given. But this is a silent behavior change. And I think it's safer
to fail if path option and `paths` are both specified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
