Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5268#discussion_r27446421
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -91,17 +103,25 @@ private[spark] class HeartbeatReceiver(sc:
SparkContext, scheduler: TaskSchedule
scheduler.executorLost(executorId, SlaveLost("Executor heartbeat "
+
s"timed out after ${now - lastSeenMs} ms"))
if (sc.supportDynamicAllocation) {
- sc.killExecutor(executorId)
+ // Asynchronously kill the executor to avoid blocking the
current thread
--- End diff --
was it not doing async before? if it wasn't, why do we need to change it
here? If it was, did the RPC contract changed it so that it is no longer async?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
