viirya commented on a change in pull request #29349:
URL: https://github.com/apache/spark/pull/29349#discussion_r466845295
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BinaryComparisonSimplificationSuite.scala
##########
@@ -119,9 +119,7 @@ class BinaryComparisonSimplificationSuite extends PlanTest
with PredicateHelper
// GetStructField with different names are semantically equal; thus,
`EqualTo(fieldA1, fieldA2)`
// will be optimized to `TrueLiteral` by `SimplifyBinaryComparison`.
- val originalQuery = nonNullableRelation
- .where(EqualTo(fieldA1, fieldA2))
- .analyze
+ val originalQuery = nonNullableRelation.where(EqualTo(fieldA1, fieldA2))
Review comment:
I go to look at this test and its original PR. `fieldA1` and `fieldA2`
are not different in letter case, but the `name` in `GetStructField`. That is
why above comment is `GetStructField with different names are semantically
equal`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
