LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-670359133
The main change of Address [beb3928](https://github.com/apache/spark/pull/29370/commits/beb3928397a81b2dd65d885b4e40e6e3c65376a3) is call `toMap` method of `Metadata#hash` method `case map` branch because `map.mapValues` return `Map` in Scala 2.12 and return `MapView` in Scala 2.13. The effect as follow: - Let `ExpressionSetSuite` no longer ABORTEDbut add 1 failed case because of `ExpressionSet` not implement `++` method - Pass `MetadataSuite ` **Before** ``` Tests: succeeded 3925, failed 31, canceled 0, ignored 6, pending 0 *** 3 SUITES ABORTED *** *** 31 TESTS FAILED *** ``` **After** ``` Tests: succeeded 3973, failed 31, canceled 0, ignored 6, pending 0 *** 2 SUITES ABORTED *** *** 31 TESTS FAILED *** ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
