maropu opened a new pull request #29384:
URL: https://github.com/apache/spark/pull/29384
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
`TPCDSQuerySuite` currently computes plans with empty TPCDS tables, then
checks if plans can be generated correctly. But, the generated plans can be
different from actual ones because the input tables are empty (e.g., the plans
always use broadcast-hash joins, but actual ones use sort-merge joins for
larger tables). To mitigate the issue, this PR defines data statistics
constants extracted from generated TPCDS data in `TPCDSTableStats`, then
injects the statistics via `spark.sessionState.catalog.alterTableStats` when
defining TPCDS tables in `TPCDSQuerySuite`.
Please see a link below about how to extract the table statistics:
- https://gist.github.com/maropu/f553d32c323ee803d39e2f7fa0b5a8c3
For example, the generated plans of TPCDS `q2` are different with/without
this fix:
```
==== w/ this fix: q2 ====
== Physical Plan ==
* Sort (43)
+- Exchange (42)
+- * Project (41)
+- * SortMergeJoin Inner (40)
:- * Sort (28)
: +- Exchange (27)
: +- * Project (26)
: +- * BroadcastHashJoin Inner BuildRight (25)
: :- * HashAggregate (19)
: : +- Exchange (18)
: : +- * HashAggregate (17)
: : +- * Project (16)
: : +- * BroadcastHashJoin Inner BuildRight (15)
: : :- Union (9)
: : : :- * Project (4)
: : : : +- * Filter (3)
: : : : +- * ColumnarToRow (2)
: : : : +- Scan parquet
default.web_sales (1)
: : : +- * Project (8)
: : : +- * Filter (7)
: : : +- * ColumnarToRow (6)
: : : +- Scan parquet
default.catalog_sales (5)
: : +- BroadcastExchange (14)
: : +- * Project (13)
: : +- * Filter (12)
: : +- * ColumnarToRow (11)
: : +- Scan parquet
default.date_dim (10)
: +- BroadcastExchange (24)
: +- * Project (23)
: +- * Filter (22)
: +- * ColumnarToRow (21)
: +- Scan parquet default.date_dim (20)
+- * Sort (39)
+- Exchange (38)
+- * Project (37)
+- * BroadcastHashJoin Inner BuildRight (36)
:- * HashAggregate (30)
: +- ReusedExchange (29)
+- BroadcastExchange (35)
+- * Project (34)
+- * Filter (33)
+- * ColumnarToRow (32)
+- Scan parquet default.date_dim (31)
==== w/o this fix: q2 ====
== Physical Plan ==
* Sort (40)
+- Exchange (39)
+- * Project (38)
+- * BroadcastHashJoin Inner BuildRight (37)
:- * Project (26)
: +- * BroadcastHashJoin Inner BuildRight (25)
: :- * HashAggregate (19)
: : +- Exchange (18)
: : +- * HashAggregate (17)
: : +- * Project (16)
: : +- * BroadcastHashJoin Inner BuildRight (15)
: : :- Union (9)
: : : :- * Project (4)
: : : : +- * Filter (3)
: : : : +- * ColumnarToRow (2)
: : : : +- Scan parquet default.web_sales
(1)
: : : +- * Project (8)
: : : +- * Filter (7)
: : : +- * ColumnarToRow (6)
: : : +- Scan parquet
default.catalog_sales (5)
: : +- BroadcastExchange (14)
: : +- * Project (13)
: : +- * Filter (12)
: : +- * ColumnarToRow (11)
: : +- Scan parquet default.date_dim
(10)
: +- BroadcastExchange (24)
: +- * Project (23)
: +- * Filter (22)
: +- * ColumnarToRow (21)
: +- Scan parquet default.date_dim (20)
+- BroadcastExchange (36)
+- * Project (35)
+- * BroadcastHashJoin Inner BuildRight (34)
:- * HashAggregate (28)
: +- ReusedExchange (27)
+- BroadcastExchange (33)
+- * Project (32)
+- * Filter (31)
+- * ColumnarToRow (30)
+- Scan parquet default.date_dim (29)
```
This comes from the @cloud-fan comment:
https://github.com/apache/spark/pull/29270#issuecomment-666098964
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
For better test coverage.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
