Github user hunglin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5124#discussion_r27448459
  
    --- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
    @@ -173,4 +176,21 @@ class SparkContextSuite extends FunSuite with 
LocalSparkContext {
           sc.stop()
         }
       }
    +
    +  test("Cancelling job group should not cause SparkContext to shutdown 
(SPARK-6414)") {
    +    try {
    +      sc = new SparkContext(new 
SparkConf().setAppName("test").setMaster("local"))
    +      val future = sc.parallelize(Seq(0)).foreachAsync(_ => 
{Thread.sleep(1000L)})
    +      sc.cancelJobGroup("nonExistGroupId")
    +      Await.ready(future, Duration(2, TimeUnit.SECONDS))
    +
    +      /**
    +       * In SPARK-6414, sc.cancelJobGroup will cause NullPointerException 
and cause
    --- End diff --
    
    thanks for reminding, updated the comment style.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to