karuppayya commented on a change in pull request #28804:
URL: https://github.com/apache/spark/pull/28804#discussion_r467175169
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##########
@@ -680,6 +688,16 @@ case class HashAggregateExec(
private def doProduceWithKeys(ctx: CodegenContext): String = {
val initAgg = ctx.addMutableState(CodeGenerator.JAVA_BOOLEAN, "initAgg")
+ if (skipPartialAggregate) {
+ avoidSpillInPartialAggregateTerm = ctx.
+ addMutableState(CodeGenerator.JAVA_BOOLEAN,
+ "avoidPartialAggregate",
+ term => s"$term = ${Utils.isTesting};")
Review comment:
The aggregation map memory needs to be exhausted for the optimization to
kick in.
To bypass that for testing, using the `isTesting` method to trigger the
optimization in HashAggregate operator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
