maropu commented on a change in pull request #29342:
URL: https://github.com/apache/spark/pull/29342#discussion_r467460603
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -110,10 +117,10 @@ private[execution] object HashedRelation {
if (isNullAware && !input.hasNext) {
EmptyHashedRelation
- } else if (key.length == 1 && key.head.dataType == LongType) {
+ } else if (key.length == 1 && key.head.dataType == LongType &&
!isLookupAware) {
Review comment:
Ah, I see. At first I thought we might be able to support both cases
(long/unsafe hash) if we used separate bits for unseen entries. But, I saw you
comment below and it sound reasonable to me:
https://github.com/apache/spark/pull/29342#discussion_r467173696
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
