viirya commented on a change in pull request #29342:
URL: https://github.com/apache/spark/pull/29342#discussion_r467503454



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -91,13 +96,18 @@ private[execution] object HashedRelation {
 
   /**
    * Create a HashedRelation from an Iterator of InternalRow.
+   *
+   * @param isLookupAware reserve one extra boolean in value to track if value 
being looked up

Review comment:
       Can you also mention that this is only used in full outer shuffled hash 
join?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to