HeartSaVioR commented on pull request #27620: URL: https://github.com/apache/spark/pull/27620#issuecomment-671142330
I just revisited about deduplicating CountListingLocalFileSystem, and felt that deduplication isn't safe, because the instance refers singleton object which will be co-used once we deduplicate, and calling reset may affect other test - this would depend on the characteristic of parallelism on test suite run. If it's guaranteed that test suites are never executed in parallel in same JVM then the change would be safe, otherwise it wouldn't. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
