LuciferYang commented on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-671152179
The main change of Address [4018b1f](https://github.com/apache/spark/pull/29370/commits/4018b1fb47e72f790609d4d2993e0ba90639fcc8) as follow: - `GenericArrayData` not accept `ArrayBuffer` input, call `toSeq` for Scala version compatibility - Call `toSeq` in `RandomDataGenerator#randomRow` method to ensure contents of `fields` is `Seq` not `ArrayBuffer` - Call `toSeq` Let `JacksonParser#parse` still return a `Seq` because the check method of `JacksonParserSuite#"skipping rows using pushdown filters"` dependence on `Seq` type The effect as follow: - Let `ArrayDataIndexedSeqSuite` no longer ABORTED and all pass - Pass `StringExpressionsSuite ` - Pass `JacksonParserSuite ` - Pass `HigherOrderFunctionsSuite ` - Partial Pass `CollectionExpressionsSuite ` , failed case from 6 to 3 **Before** ``` Tests: succeeded 3973, failed 31, canceled 0, ignored 6, pending 0 *** 2 SUITES ABORTED *** *** 27 TESTS FAILED *** ``` **After** ``` Tests: succeeded 4035, failed 21, canceled 0, ignored 6, pending 0 *** 1 SUITE ABORTED *** *** 21 TESTS FAILED *** ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
