Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/5286#discussion_r27454970
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -439,14 +439,10 @@ private[spark] class BlockManager(
// As an optimization for map output fetches, if the block is for a
shuffle, return it
// without acquiring a lock; the disk store never deletes (recent)
items so this should work
if (blockId.isShuffle) {
- val shuffleBlockManager = shuffleManager.shuffleBlockManager
- shuffleBlockManager.getBytes(blockId.asInstanceOf[ShuffleBlockId])
match {
- case Some(bytes) =>
- Some(bytes)
- case None =>
--- End diff --
This code path, I believe, could never be realized before, because all
implementations returned `Some`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
